Skip to content

FIX: data-loader now responds to loadKey changes #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephanwlee merged 1 commit into from
Oct 10, 2018
Merged

FIX: data-loader now responds to loadKey changes #1500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions tensorboard/components/tf_line_chart_data_loader/data-loader-behavior.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ export const DataLoaderBehavior = {
* An unique identifiable string. When changes, it expunges the data
* cache.
*/
loadKey: String,
loadKey: {
type: String,
value: '',
},

// List of data to be loaded. A datum is passed to `getDataLoadUrl` to ge
// URL of an API endpoint and, when request resolves, invokes
Expand Down Expand Up @@ -80,7 +83,6 @@ export const DataLoaderBehavior = {
},

observers: [
'_loadKeyChanged(loadKey)',
'_dataToLoadChanged(isAttached, dataToLoad.*)',
],

Expand All @@ -93,10 +95,12 @@ export const DataLoaderBehavior = {
this._loadData();
},

_loadKeyChanged(_) {
// When `key` changes, cancel all handlers from the previous requests.
this._canceller.cancelAll();
this._loadedData.clear();
reset() {
// https://github.com/tensorflow/tensorboard/issues/1499
// Cannot use the observer to observe `loadKey` changes directly.
if (this._canceller) this._canceller.cancelAll();
if (this._loadedData) this._loadedData.clear();
if (this.isAttached) this._loadData();
},

_dataToLoadChanged() {
Expand Down
1 change: 1 addition & 0 deletions tensorboard/components/tf_line_chart_data_loader/tf-line-chart-data-loader.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@
},

_loadKeyChanged(_) {
this.reset();
this._resetDomainOnNextLoad = true;
},

Expand Down