Fix multiline magic#28160
Merged
tensorflow-copybara merged 1 commit intotensorflow:masterfrom Apr 26, 2019
Merged
Conversation
Contributor
Author
|
I have a couple of questions:
I tried specifying one test for bazel, but seems like bazel anyway tries to rebuild the universe:( |
Contributor
Author
|
cc @martinwicke |
Contributor
Author
|
Something to be aware of: with implemented approach to multiline-magic, the python tensorflow code, that is used in |
Member
|
This is better than not handling multi-line properly. Is there a list of %% directives we should exclude? If timeit is the only real issue, we could special-case it. |
martinwicke
approved these changes
Apr 26, 2019
tensorflow-bot
bot
added
kokoro:force-run
tensorflow-copybara
pushed a commit
that referenced
this pull request
Apr 26, 2019
PiperOrigin-RevId: 245482882
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, the feature for multiline introduced by another contributor in 9355771#diff-db01673eb6e019b39689cd41bfae3d5e breaks notebook cell alignment.
The problem is that we skip the cell, during
_get_code, but do not skip the same cells during_update_notebook. As a result, the diffs, that have such multiline magic, are alignedThis PR should fix the problem.