Fix conv1d eager/graph mode inconsistency for zero-sized output#112639
Open
ayushozha wants to merge 1 commit intotensorflow:masterfrom
Open
Fix conv1d eager/graph mode inconsistency for zero-sized output#112639ayushozha wants to merge 1 commit intotensorflow:masterfrom
ayushozha wants to merge 1 commit intotensorflow:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
d340e24 to
3e7e04f
Compare
…flow#112371) Add validation in conv1d to raise ValueError when the output spatial dimension would be negative with VALID padding. Previously, eager mode silently produced a zero-sized tensor while graph mode raised an error. Now both modes raise a consistent ValueError.
3e7e04f to
d7f85f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tf.nn.conv1dwith VALID padding silently produces a zero-sized tensor in eager mode when the kernel is larger than the input, while graph mode (tf.function) raises aValueErrorconv1dthat checks if the output spatial dimension would be negative with VALID padding, raising a consistentValueErrorin both execution modesTest plan
tf.nn.conv1d(tf.zeros([1, 2, 1]), tf.zeros([5, 1, 1]), stride=1, padding='VALID')now raisesValueErrorin eager mode@tf.functionstill raisesValueErrorwith a similar message🤖 Generated with Claude Code