Optimize xla::HloDataflowAnalysis::OptimizePhiValues.#117454
Merged
Conversation
copybara-service
Bot
force-pushed
the
exported_pr_909054043
branch
2 times, most recently
from
fb977b7 to
6b59bc6
Compare
- `auto values = value_set->values();` was doing a whole `vector` copy! E.g. check out https://godbolt.org/z/YfMbrY9hY. - Reserve `new_values` vector because we are adding exactly `values.size()` elements. - Use the `HloValueSet`'s constructor (involves one sorting) instead of repeated `AddValue` calls (involve N `std::lower_bound` calls, N `vector::insert` calls). PiperOrigin-RevId: 909097719
copybara-service
Bot
force-pushed
the
exported_pr_909054043
branch
from
6b59bc6 to
8f0f1ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize
xla::HloDataflowAnalysis::OptimizePhiValues.auto values = value_set->values();was doing a wholevectorcopy!E.g. check out https://godbolt.org/z/YfMbrY9hY.
new_valuesvector because we are adding exactlyvalues.size()elements.HloValueSet's constructor (involves one sorting) instead of repeatedAddValuecalls (involve Nstd::lower_boundcalls, Nvector::insertcalls).