Fix build issue with KafkaDataset#17418
Merged
gunan merged 10 commits intotensorflow:masterfrom Mar 8, 2018
Merged
Conversation
This fix tries to address the issue raised in 17210 where error of `NotFoundError: Op type not registered 'KafkaDataset' in binary.` returned from kafka ops. The issue was that the inclusion of kafka ops was removed due to the conflict merge from the other PR. This fix fixes the issue. This fix fixes 17210. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
due to the changes in some other places. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
mrry
reviewed
Mar 6, 2018
tensorflow/core/kernels/BUILD
Outdated
| deps = [":lookup"], | ||
| ) | ||
|
|
||
| cc_library( |
Contributor
There was a problem hiding this comment.
This new library shouldn't be necessary. The dataset.h header is now in tensorflow/core/framework and can be included via the //tensorflow/core:framework_headers_lib target.
You might want to check out the targets in //tensorflow/contrib/data/... that build dataset implementations as custom op libraries. This has changed in the last month or so, as we've refactored things to make separate compilation possible for dataset implementations.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
mrry
approved these changes
Mar 6, 2018
Contributor
mrry
left a comment
mrry
left a comment
There was a problem hiding this comment.
Neat! Thanks for making those changes. LGTM.
Member
Author
|
Thanks @mrry for the help 👍 . Some of the tests are failing. Seems to be some difference between clang and gcc (it runs fine on my local machine with gcc + ubuntu 16.04). I am looking into the issue now. |
yongtang
force-pushed
the
17210-KafkaDataset
branch
from
eddcba0 to
3f19308
Compare
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
yongtang
force-pushed
the
17210-KafkaDataset
branch
from
3f19308 to
7bd4881
Compare
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
yongtang
force-pushed
the
17210-KafkaDataset
branch
2 times, most recently
from
6699684 to
a3e4a55
Compare
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
yongtang
force-pushed
the
17210-KafkaDataset
branch
from
a3e4a55 to
c1eaba4
Compare
Member
Author
|
The reason of the previous test failure was that, All tests passed now 🎉 |
StanislawAntol
pushed a commit
to StanislawAntol/tensorflow
that referenced
this pull request
Mar 23, 2018
* Fix build issue with KafkaDataset This fix tries to address the issue raised in 17210 where error of `NotFoundError: Op type not registered 'KafkaDataset' in binary.` returned from kafka ops. The issue was that the inclusion of kafka ops was removed due to the conflict merge from the other PR. This fix fixes the issue. This fix fixes 17210. Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Change `import readers.Dataset` to `import dataset_ops.Dataset`, due to the changes in some other places. Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Fix library dependency issues in bazel Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Add dependency to bazel rules Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Add license to lib and pip package Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Remove unneeded changes in bazel Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Address review feedback Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Fix sanity check Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Add zlib dependency and include path Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Add copts in bazel to address the discrepancy in clang and gcc Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix tries to address the issue raised in #17210 where error of
NotFoundError: Op type not registered 'KafkaDataset' in binary.returned from kafka ops.The issue was that the inclusion of kafka ops was removed due to the conflict merge from the other PR. This fix fixes the issue.
This fix fixes #17210.
Signed-off-by: Yong Tang yong.tang.github@outlook.com