contrib/eagerpython/datasets: Resource naming workaround.#19786
Merged
av8ramit merged 1 commit intotensorflow:masterfrom Jun 5, 2018
asimshankar:anon-iter
Merged
contrib/eagerpython/datasets: Resource naming workaround.#19786av8ramit merged 1 commit intotensorflow:masterfrom asimshankar:anon-iter
av8ramit merged 1 commit intotensorflow:masterfrom
asimshankar:anon-iter
Conversation
tensorflow/contrib/eager/python/datasets_test.py was failing on GPU because two tests - testTensorsPlacedOnDevice() and testTensorsExplicitPrefetchToDevice() we're creating FunctionBufferResources with the same shared_name, leading to unintentional interference. This change will make the tests pass and allow the use of tf.contrib.eager.Iterator and tf.data.Dataset.apply(prefetching_ops.prefetch_to_device) in the same process without interference. However, a more appropriate fix would probably be to use anonymous function buffering resources (similar to AnonymousIteratorHandle) when eager execution is enabled, doing away with sharing by name.
mrry
approved these changes
Jun 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tensorflow/contrib/eager/python/datasets_test.py was failing on GPU
because two tests - testTensorsPlacedOnDevice() and
testTensorsExplicitPrefetchToDevice() we're creating
FunctionBufferResources with the same shared_name, leading to
unintentional interference.
This change will make the tests pass and allow the use of
tf.contrib.eager.Iterator and
tf.data.Dataset.apply(prefetching_ops.prefetch_to_device)
in the same process without interference.
However, a more appropriate fix would probably be to use
anonymous function buffering resources (similar to
AnonymousIteratorHandle) when eager execution is enabled,
doing away with sharing by name.
CC @allenlavoie @rohan100jain @mrry @av8ramit