Make implementation of GrpcServer::Init with Collective Ops compatible with calls in contrib/mpi#19942
Merged
caisq merged 3 commits intotensorflow:masterfrom Jun 13, 2018
emaballarin:master
Merged
Make implementation of GrpcServer::Init with Collective Ops compatible with calls in contrib/mpi#19942caisq merged 3 commits intotensorflow:masterfrom emaballarin:master
caisq merged 3 commits intotensorflow:masterfrom
emaballarin:master
Conversation
caisq
added
awaiting review
poxvoculi
previously approved these changes
Jun 12, 2018
A `)` was missing.
Contributor
Author
|
Sorry for the additional noise (and additional commit). Having to compile TF with GCC 8.1/OpenMPI 3.1, and thus having to patch some MPI-related code to make it compile, I ported the changes for the PR by hand. Indeed, a closing brace was deleted together with the argument. This (probably) explains the CI tests failures. I'm very sorry for that. Now it should be fixed. |
caisq
added
kokoro:force-run
Contributor
|
It appears that there is some tool failure in the "MacOS Python2 and CC" kokoro test. Starting test again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes compilation errors outlined in #19924.
I haven't tested the actual MPI behavior (just that compilation succeeds). However, an if-clause in
grpc_server_lib.ccguards the case in whichcollective_mgr_funcis not explicitly passed.