Skip to content

[ROCm] rocBLAS BLAS algorithms integration logic in ROCm StreamExecutor#20715

Closed
whchung wants to merge 4 commits intotensorflow:masterfrom
ROCm:upstream-staging-stream-executor-blas
Closed

[ROCm] rocBLAS BLAS algorithms integration logic in ROCm StreamExecutor#20715
whchung wants to merge 4 commits intotensorflow:masterfrom
ROCm:upstream-staging-stream-executor-blas

Conversation

@whchung
Copy link
Copy Markdown
Contributor

@whchung whchung commented Jul 11, 2018

Please focus on the content in commit c12b7df

The pull request contains rocBLAS integration logic for ROCm platform.

There are additional changes included in this pull request which are covered
in other pull requests for ROCm. In order to ensure each pull request is
self-contained and builds / runs on both CUDA & ROCm platform they are still
included here.

Authors:

@whchung
Copy link
Copy Markdown
Contributor Author

whchung commented Jul 11, 2018

@jlebar This is the subsequent PR after #20709 to cover integration logic for rocBLAS BLAS algorithms on ROCm StreamExecutor implementation

@jlebar
Copy link
Copy Markdown
Contributor

jlebar commented Jul 11, 2018

cc @chsigg

The commit contains following components to support TensorFlow on ROCm platform

- bazel build system
- continuous integration logic

Authors:

- Jack Chung: jack.chung@amd.com
- Jeffrey Poznanovic: Jeffrey.Poznanovic@amd.com
- Peng Sun: Peng.Sun@amd.com
@whchung whchung force-pushed the upstream-staging-stream-executor-blas branch from 4a09fa2 to c12b7df Compare July 11, 2018 23:51
@qlzh727 qlzh727 requested review from chsigg and jlebar July 12, 2018 17:20
@qlzh727 qlzh727 added awaiting review Pull request awaiting review kokoro:run labels Jul 12, 2018
whchung added 3 commits July 12, 2018 17:22
…ROCm

1) StreamInterface::CudaStreamMemberHack()

Despite the fact that StreamExecutor and GPU common runtime are largely
orthogonal, this particular routine in StreamExecutor is used in GPU common
runtime and a couple of other operators. In this commit it's renamed as
StreamInterface::GpuStreamMemberHack() and their call sites are also changed.

2) StreamExecutorInterface::CudaContextHack()

This member is renamed to StramExecutorInterface::GpuContextHack().

Changes introduced in this commit includes:

- some StreamExecutor interfaces and CUDA implementation
- GPU common runtime related to interface changes in StreamExecutor
- operators affected by interface changes in StreamExecutor
The commit contains StreamExecutor logic for ROCm platform. It includes
integration logic with major components on ROCm platform:

- HIP runtime APIs
- rocRAND for RNG

Also included are relevant changes to:

- bazel script to build ROCm StreamExecutor on ROCm platform

Authors:

- Jack Chung: jack.chung@amd.com
- Deven Desai: deven.desai@amd.com
- Johannes M Dieterich: Johannes.Dieterich@amd.com
- Peng Sun: Peng.Sun@amd.com
- Jeffrey Poznanovic: Jeffrey.Poznanovic@amd.com
This commit contains integration logic for rocBLAS on ROCm platform.
@qlzh727
Copy link
Copy Markdown
Member

qlzh727 commented Aug 9, 2018

@whchung, is this PR still alive? Please resolve the merge conflict if this is the case.

@qlzh727 qlzh727 added the stat:awaiting response Status - Awaiting response from author label Aug 9, 2018
@whchung
Copy link
Copy Markdown
Contributor Author

whchung commented Aug 9, 2018

@qlzh727 all of my PRs are still alive. it's just literally they all hinge on #20277 where I have to fix issues met on Mac / Windows and certain Ubuntu build targets. I'll rebase and revise the PR once #20277 lands

@tensorflowbutler tensorflowbutler removed the stat:awaiting response Status - Awaiting response from author label Aug 10, 2018
@qlzh727 qlzh727 added stat:awaiting response Status - Awaiting response from author and removed awaiting review Pull request awaiting review labels Aug 29, 2018
@tensorflowbutler tensorflowbutler added the stale This label marks the issue/pr stale - to be closed automatically if no activity label Sep 13, 2018
@tensorflowbutler
Copy link
Copy Markdown
Member

It has been 14 days with no activity and the awaiting response label was assigned. Is this PR still valid? Assigning the stalled label. Please comment to reassure me that this is still being worked on.

@tensorflowbutler
Copy link
Copy Markdown
Member

It has been 43 days that this pull-request has stalled. Please create a new pull-request with the requested changes.

@sunway513 sunway513 deleted the upstream-staging-stream-executor-blas branch May 4, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes stale This label marks the issue/pr stale - to be closed automatically if no activity stat:awaiting response Status - Awaiting response from author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants