Skip to content

Adding MKL DNN license from Intel's repo#20810

Merged
tensorflow-copybara merged 1 commit intotensorflow:masterfrom
sadatnfs:master
Jul 16, 2018
Merged

Adding MKL DNN license from Intel's repo#20810
tensorflow-copybara merged 1 commit intotensorflow:masterfrom
sadatnfs:master

Conversation

@sadatnfs
Copy link
Copy Markdown

@sadatnfs sadatnfs commented Jul 15, 2018

Adding the LICENSE file so that third_party/mkl_dnn LICENSE file is picked up upon MKL configured build.

This build works now in a Docker (refer to #20811), where initially the missingness of the MKL-DNN LICENSE file would error out since commit #20576 forces the check for the DNN license.

bazel build --config=opt --config=mkl \
    tensorflow/tools/pip_package:build_pip_package 

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@sadatnfs
Copy link
Copy Markdown
Author

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright {yyyy} {name of copyright owner}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this place holder accordingly

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qlzh727 I think this is meant to be a template and not having actual values.

@sadatnfs
Copy link
Copy Markdown
Author

@qlzh727 hmm it looks like the MKL LICENSE file in third_party/mkl/LICENSE also has the two fileds as blank. We should be consistent with that eh?

@qlzh727
Copy link
Copy Markdown
Member

qlzh727 commented Jul 16, 2018

I think they they should be consistent. Also waiting for input from @martinwicke who probably have more detailed knowledge.

@sadatnfs
Copy link
Copy Markdown
Author

Hmm is there a reason why import/copybara check failed?

@qlzh727 qlzh727 added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Jul 16, 2018
@qlzh727
Copy link
Copy Markdown
Member

qlzh727 commented Jul 16, 2018

@yifeif, not sure why copybara is not porting the PR to internal.

@yifeif
Copy link
Copy Markdown
Contributor

yifeif commented Jul 16, 2018

Discussed offline with @qlzh727. Fixed now.

@tensorflow-copybara tensorflow-copybara merged commit 081a8a1 into tensorflow:master Jul 16, 2018
tensorflow-copybara pushed a commit that referenced this pull request Jul 16, 2018
PiperOrigin-RevId: 204823101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes ready to pull PR ready for merge process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants