Fix for the broken "--config=rocm" build (followup to PR 20277)#22658
Closed
deven-amd wants to merge 1 commit intotensorflow:masterfrom
Closed
Fix for the broken "--config=rocm" build (followup to PR 20277)#22658deven-amd wants to merge 1 commit intotensorflow:masterfrom
deven-amd wants to merge 1 commit intotensorflow:masterfrom
Conversation
|
@yifeif did you get a chance to review this PR? |
Contributor
Contributor
|
closing this PR based on @yifeif 's statement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more of a followup to PR #20277
As per the following comment by @yifeif
#20277 (comment)
if_cuda_is_configuredwas changed toif_cudain the merge to make some internal targets pass. Unfortunately it seems that doing so break theROCmbuild.When I try to do a
ROCmbuild on a clean repo (post PR 20277masterbranch), I get the following errorsThe following commands can be used to do the
ROCmbuildThis build does complete without any errors with the commit in this PR.
I realize that this commit will most likely cause regressions in the internal targets/builds that @yifeif eluded to in the comment. So we need to come up with a solution that makes everything work, and we will need your help in that matter.