PosixFileSystem::CopyFile: Truncate file before overwrite#28510
Conversation
|
@tsawada could you please resolve the conflicts? Thanks! |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
Without O_TRUNC, the original content of the target file will be left over if the src file is shorter.
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Oops, I force pushed a wrong branch with ill rebasing operation. I just did another force-push that is correctly rebased on the latest master. |
|
Let me know if I should make another rebase to fix failing builds. It seems those builds were broken on master when I did last rebase. |
Without O_TRUNC, the original content of the target file will be left
over if the src file is shorter.
Fixes #28508