[ROCm] hip-clang (3.5) bugfixes #42288
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deven-amd
reviewed
Aug 13, 2020
Comment on lines
282
to
285
| #if TENSORFLOW_COMPILER_IS_HIP_CLANG | ||
| // HIP-CLANG has some kind of problem here with 32 threads (possibly because | ||
| // the warpsize is 64). Reenable when working properly | ||
| } else if (true) { |
There was a problem hiding this comment.
@ekuznetsov139
this part is already upstreamed....see lines 251-254 above
chsigg
previously approved these changes
Aug 19, 2020
google-ml-butler
bot
added
kokoro:force-run
deven-amd
added a commit
to ROCm/tensorflow-upstream
that referenced
this pull request
Aug 26, 2020
ekuznetsov139
force-pushed
the
google-upstream-rocm35-0812
branch
from
599dd70 to
0940c65
Compare
ekuznetsov139
force-pushed
the
google-upstream-rocm35-0812
branch
from
0940c65 to
c6df176
Compare
deven-amd
added a commit
to ROCm/tensorflow-upstream
that referenced
this pull request
Sep 24, 2020
tensorflow-copybara
pushed a commit
that referenced
this pull request
Sep 25, 2020
…ocm35-0812 PiperOrigin-RevId: 333738541 Change-Id: Ic848afd875bb7dee980bd7c47a637ae6189f90e3
|
Changes have been merged into master by commit eb0f1ed. So closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few problems that surfaced in ROCm after the switch to hip-clang with version 3.5.