[MLIR] TF Graphdef to MLIR python binding: input/output options#49380
Merged
copybara-service[bot] merged 1 commit intotensorflow:masterfrom Jun 21, 2021
Merged
[MLIR] TF Graphdef to MLIR python binding: input/output options#49380copybara-service[bot] merged 1 commit intotensorflow:masterfrom
copybara-service[bot] merged 1 commit intotensorflow:masterfrom
Conversation
joker-eph
reviewed
May 20, 2021
bondhugula
suggested changes
May 21, 2021
pashu123
force-pushed
the
upstream_changes
branch
2 times, most recently
from
409d4cd to
1f5e0dd
Compare
joker-eph
reviewed
May 21, 2021
pashu123
force-pushed
the
upstream_changes
branch
from
1f5e0dd to
ef6b555
Compare
pashu123
force-pushed
the
upstream_changes
branch
3 times, most recently
from
066c523 to
c900371
Compare
joker-eph
reviewed
Jun 16, 2021
pashu123
force-pushed
the
upstream_changes
branch
3 times, most recently
from
82ec9bc to
7b88dbd
Compare
joker-eph
reviewed
Jun 17, 2021
joker-eph
reviewed
Jun 17, 2021
pashu123
force-pushed
the
upstream_changes
branch
from
7b88dbd to
0b9fb65
Compare
Update the Python binding from Graphdef to TF-MLIR with input/output options - add non-trivial test cases.
pashu123
force-pushed
the
upstream_changes
branch
from
0b9fb65 to
beaa0a1
Compare
joker-eph
approved these changes
Jun 17, 2021
google-ml-butler
bot
added
kokoro:force-run
| } | ||
| node_shapes.push_back(dims); | ||
| } | ||
| std::vector<string> output_nodes = absl::StrSplit(output_names, ','); |
There was a problem hiding this comment.
Looks like if output_names is empty (e.g. because output_names=[] was passed to import_graphdef) this results in an error:
tensorflow.python.framework.errors_impl.InvalidArgumentError: Output was not found in graph
It may be enough to do
if (!output_names.empty()) {
std::vector<string> output_nodes = absl::StrSplit(output_names, ',');
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the Python binding from Graphdef to TF-MLIR with input/output
options - add non-trivial test cases.