Skip to content

Branch 141962539#6296

Merged
martinwicke merged 112 commits into
tensorflow:masterfrom
martinwicke:branch_141962539
Dec 14, 2016
Merged

Branch 141962539#6296
martinwicke merged 112 commits into
tensorflow:masterfrom
martinwicke:branch_141962539

Conversation

@martinwicke
Copy link
Copy Markdown
Member

No description provided.

Joshua V. Dillon and others added 30 commits December 9, 2016 12:05
…ctor.is_constant_jacobian.

Change: 141581989
…ray.stack

and TensorArray.unstack since pack and unpack are getting deprecated. Also, I switched a few references to tf.pack/tf.unpack to tf.stack and tf.unstack.
Change: 141589815
…42 because

they cause test timeouts.
Change: 141590858
Must compute dimension size explicitly rather than using [-1] in order to deal with all multidimensional Tensors with dimensions after first equal to zero.
Change: 141601835
…ray.stack

and TensorArray.unstack since pack and unpack are getting deprecated. Also, I switched a few references to tf.pack/tf.unpack to tf.stack and tf.unstack.
Change: 141616518
…ray.stack

and TensorArray.unstack since pack and unpack are getting deprecated. Also, I switched a few references to tf.pack/tf.unpack to tf.stack and tf.unstack.
Change: 141619037
Without names they can't be refactored.
Change: 141621006
op and the python use in the same change violates forwards compatibility.

Keep the op registered.
Change: 141622306
This should make bazel fetch significiantly faster and more reliable.
Change: 141627448
…ray.stack

and TensorArray.unstack since pack and unpack are getting deprecated. Also, I switched a few references to tf.pack/tf.unpack to tf.stack and tf.unstack.
Change: 141630998
Previously, is_inf_or_nan errors out if the dtype of the tensor (numpy array) is not float, complex or integer. This CL adds guard against such data types.
Change: 141671477
…on in another partition. To order to work correctly with dedup of single-source-multiple-destination, we require that source node can only have one outgoing control edges.

Change: 141675118
Making self._features_info vary by mode, as implemented, causes various test failures.  We can consider doing it (more carefully) but need to revert for now as the broken build blocks other CLs.
Change: 141702821
mrry and others added 13 commits December 13, 2016 14:02
…ict. Allow initial state to be specified by returning state tensors from input_fn.

Change: 141937736
…hat transform string features to IDs, where the mapping is defined by a vocabulary file.

Change: 141945123
For some reason I thought the name was broken...so I wrote this test.  Might as
well use it.
Change: 141945959
Usage examples:
tfdbg> pt cross_entropy/Log:0 > /tmp/log_0.txt
tfdbg> pt cross_entropy/Log:0[0, :] > /tmp/log_0_slice.txt
tfdbg> li -r cross_entropy/Log:0 >/tmp/log_0_inputs.txt
tfdbg> ni cross_entropy/Log:0>/tmp/log_0_node_info.txt
tfdbg> lt> /tmp/tensor_list.txt
Change: 141949497
This change introduces a new `LocalMaster` class, which enables
distributed TensorFlow sessions to communicate directly with a master
in the same process, without making a loopback RPC call.

This improves the performance on some distributed session microbenchmarks:

* The median step time for a minimal step decreases from 392us to 273us.
* The median step time for a step that feeds 4MB of data decreases from
  9.26ms to 5.26ms.

This change is a first step towards addressing issue tensorflow#6256. The code
contains TODO comments with several further potential improvements:

* TODO(mrry): Add methods that avoid protobuf encoding the request/response
  objects where this affects performance.
* TODO(mrry): Avoid closure creation/context switch overhead for synchronous
  invocation of Master methods.
* TODO(mrry): Apply a similar change to the WorkerInterface.
Change: 141950977
Change: 141951932
Before this CL, XLA GPU binaries can only be run with "blaze test". After this
CL, they can be run directly via "blaze-bin/<executable>".
Change: 141952101
Change: 141962539
@caisq
Copy link
Copy Markdown
Contributor

caisq commented Dec 14, 2016

@tensorflow-jenkins test this please

@caisq
Copy link
Copy Markdown
Contributor

caisq commented Dec 14, 2016

//tensorflow/python/kernel_tests:variable_scope_test failure seems to be legit, reproducible failure. This failure is not seen on CL postsubmit tests. So I guess it is caused by a clash with a external PR. This one looks like a candidate: 0958bb7

@martinwicke
Copy link
Copy Markdown
Member Author

I'm fixing it, slowly. I'll handle this, you should go sleep.

@martinwicke
Copy link
Copy Markdown
Member Author

There was a large change affecting the behavior if zeros_initializer by @itsmeolivia, which the external PR wasn't aware of. Soon...

@martinwicke
Copy link
Copy Markdown
Member Author

@mrry can you help with the cmake failure? I think it's new kernels in contrib, how should these be added to the cmake build?

@mrry
Copy link
Copy Markdown
Contributor

mrry commented Dec 14, 2016

You need to add a line here:

GENERATE_PYTHON_OP_LIB("contrib_tensor_forest_ops"
  DESTINATION ${CMAKE_CURRENT_BINARY_DIR}/tf_python/tensorflow/contrib/tensor_forest/python/ops/gen_tensor_forest_ops.py)

It looks like the kernels are already built (see here), but the op registrations are missing, so we'll need another line here like:

GENERATE_CONTRIB_OP_LIBRARY(tensor_forest "${tensorflow_source_dir}/tensorflow/contrib/tensor_forest/ops/tensor_forest_ops.cc")

@martinwicke
Copy link
Copy Markdown
Member Author

Thank you, that worked.

@martinwicke martinwicke merged commit a304537 into tensorflow:master Dec 14, 2016
@martinwicke martinwicke deleted the branch_141962539 branch December 14, 2016 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.