Skip to content

Flax 0.6.3 circular dependency in Bazel build #7159

@mattsoulanille

Description

@mattsoulanille

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template

System information

  • Have I written custom code (as opposed to using a stock example script provided in TensorFlow.js):
  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): GCP CI Docker
  • Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
  • TensorFlow.js installed from (npm or script link):
  • TensorFlow.js version (use command below):
  • Browser version:
  • Tensorflow.js Converter Version:

Describe the current behavior

When running presubmits, the following error appears.

ERROR: /usr/local/google/home/msoulanille/.cache/bazel/_bazel_msoulanille/9633cfa0c28af5f24d900dd13e6bc5b8/external/tensorflowjs_dev_deps/pypi__flax/BUILD.bazel:22:11: in py_library rule @tensorflowjs_dev_deps//pypi__flax:pypi__flax: cycle in dependency graph:
    //tfjs-converter/python/tensorflowjs/converters:jax_conversion_test (1ac704f01a0ba260bfb1a01d72a5e91827144d78836864b5710509d3d9d956a2)
    //tfjs-converter/python/tensorflowjs:expect_flax_installed (c57eef692cab50e751ca54fdd64a9d8b7f624d9bccb12be15778f5c2d8865e6c)
.-> @tensorflowjs_dev_deps//pypi__flax:pypi__flax (c57eef692cab50e751ca54fdd64a9d8b7f624d9bccb12be15778f5c2d8865e6c)
|   @tensorflowjs_dev_deps//pypi__orbax:pypi__orbax (c57eef692cab50e751ca54fdd64a9d8b7f624d9bccb12be15778f5c2d8865e6c)
`-- @tensorflowjs_dev_deps//pypi__flax:pypi__flax (c57eef692cab50e751ca54fdd64a9d8b7f624d9bccb12be15778f5c2d8865e6c)

Describe the expected behavior
No error.

Standalone code to reproduce the issue
Revert #7158 and run CI presubmits (creating a PR is one way to do this, or run ./scripts/run_bazel_ci_tests.sh in the root of the repo).

Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions