Skip to content

Conversation

@nsthorat
Copy link
Contributor

@nsthorat nsthorat commented Aug 19, 2019

I didn't add this commit to the last PR, following up.


This change is Reviewable

Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I was asking you before :)

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov)

@nsthorat
Copy link
Contributor Author

This PR was the start but I didn't push these final changes: #1835

@nsthorat nsthorat merged commit 429c379 into master Aug 19, 2019
@nsthorat nsthorat deleted the release-script branch August 19, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants