Skip to content

Add uncommited changes to the release script to support multi-package PR version bumps. #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 19, 2019
Merged

Add uncommited changes to the release script to support multi-package PR version bumps. #1855

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c181b15
Update release script to send a single PR when multiple packages upda…
Aug 15, 2019
0900e4f
Merge branch 'master' into release-script
Aug 15, 2019
120c489
Merge remote-tracking branch 'origin' into release-script
Aug 19, 2019
dc4133e
save
Aug 19, 2019
3567bed
save
Aug 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions scripts/release.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,29 +121,27 @@ async function main() {
const packages = PHASES[phaseInt].packages;
const deps = PHASES[phaseInt].deps || [];

const dir = `${TMP_DIR}/tfjs`;
mkdirp(TMP_DIR, err => {
if (err) {
console.log('Error creating temp dir', TMP_DIR);
process.exit(1);
}
});
$(`rm -f -r ${dir}/*`);
$(`rm -f -r ${dir}`);
$(`mkdir ${dir}`);
$(`git clone https://github.com/tensorflow/tfjs ${dir} --depth=1`);
shell.cd(dir);

const newVersions = [];
for (let i = 0; i < packages.length; i++) {
const packageName = packages[i];

mkdirp(TMP_DIR, (err) => {
if (err) {
console.log('Error creating temp dir', TMP_DIR);
process.exit(1);
}
});
$(`rm -f -r ${TMP_DIR}/${packageName}/*`);
$(`rm -f -r ${TMP_DIR}/${packageName}`);
shell.cd(packageName);

const depsLatestVersion: string[] =
deps.map(dep => $(`npm view @tensorflow/${dep} dist-tags.latest`));

const dir = `${TMP_DIR}/${packageName}`;
$(`mkdir ${dir}`);
$(`git clone https://github.com/tensorflow/tfjs ${dir} --depth=1`);

shell.cd(dir);
shell.cd(packageName);

// Update the version.
let pkg = `${fs.readFileSync(`${dir}/${packageName}/package.json`)}`;
const parsedPkg = JSON.parse(`${pkg}`);
Expand Down Expand Up @@ -210,6 +208,7 @@ async function main() {
}

newVersions.push(newVersion);
shell.cd('..');
}

const packageNames = packages.join(', ');
Expand Down