Skip to content

Conversation

@dsmilkov
Copy link
Contributor

@dsmilkov dsmilkov commented Sep 3, 2019

Upstream fixes that were made internally to satisfy strict Closure rules


This change is Reviewable

Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @nsthorat)

@dsmilkov dsmilkov merged commit 74ff50d into master Sep 3, 2019
@dsmilkov dsmilkov deleted the upstream-closure-fix branch September 3, 2019 15:04
TomLuna added a commit to LunaOn/tfjs that referenced this pull request Sep 4, 2019
* 'master' of https://github.com/lunaon/tfjs:
  Throw a better error message when using negative begin indexing. (tensorflow#1965)
  [tfjs-core] Fix browser.fromPixels to work without needing read… (tensorflow#1947)
  [tfjs] Fix security vulnerability for tfjs. (tensorflow#1966)
  Remove the systemFetch export from platform_node (tensorflow#1963)
  Fix the release script to work with other repos (website). (tensorflow#1922)
  webgpu: Bump dependency and version. (tensorflow#1962)
  change location of logs (tensorflow#1961)
  [tfjs-core] Upstream the closure fixes (tensorflow#1960)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants