Remove the systemFetch export from platform_node #1963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmilkov
approved these changes
Sep 3, 2019
Contributor
dsmilkov
left a comment
dsmilkov
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @dsmilkov)
|
Thanks! Note that you already were working against ES2015 module semantics (hence the ts-ignores that you can now remove), and things just happened to work because the actual code ran as a CommonJS module. So in terms of strictness - Closure modules > ES2015 modules > CommonJS modules. |
Contributor
Author
|
Ah totally makes sense @rkirov, thank you! |
TomLuna
added a commit
to LunaOn/tfjs
that referenced
this pull request
Sep 4, 2019
* 'master' of https://github.com/lunaon/tfjs: Throw a better error message when using negative begin indexing. (tensorflow#1965) [tfjs-core] Fix browser.fromPixels to work without needing read… (tensorflow#1947) [tfjs] Fix security vulnerability for tfjs. (tensorflow#1966) Remove the systemFetch export from platform_node (tensorflow#1963) Fix the release script to work with other repos (website). (tensorflow#1922) webgpu: Bump dependency and version. (tensorflow#1962) change location of logs (tensorflow#1961) [tfjs-core] Upstream the closure fixes (tensorflow#1960)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closure doesn't like exported objects.
This change is