Skip to content

[tfjs-vis] Update barchart & histrogram tooltips #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2019
Merged

[tfjs-vis] Update barchart & histrogram tooltips #2070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f114f1f
update barchart & histrogram tooltips
tafsiri Sep 19, 2019
2678cf2
Merge branch 'master' into vis-consistent-tooltips
tafsiri Sep 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tfjs-vis/src/render/barchart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,10 @@ export async function barchart(
}
},
'data': {'values': values, 'name': 'values'},
'mark': 'bar',
'mark': {
'type': 'bar',
'tooltip': true,
},
'encoding': {
'x': {'field': 'index', 'type': xType, 'axis': xAxis},
'y': {'field': 'value', 'type': yType, 'axis': yAxis}
Expand All @@ -124,8 +127,8 @@ const defaultOpts = {
fontSize: 11,
};

// We keep a map of containers to chart instances in order to reuse the instance
// where possible.
// We keep a map of containers to chart instances in order to reuse the
// instance where possible.
const instances: Map<HTMLElement, InstanceInfo> =
new Map<HTMLElement, InstanceInfo>();

Expand Down
5 changes: 4 additions & 1 deletion tfjs-vis/src/render/histogram.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,10 @@ export async function histogram(
'resize': true,
},
'data': {'values': filtered},
'mark': 'bar',
'mark': {
'type': 'bar',
'tooltip': true,
},
'config': {
'axis': {
'labelFontSize': options.fontSize,
Expand Down