Skip to content

tf.broadcastTo #2238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 21, 2019
Merged

tf.broadcastTo #2238

merged 9 commits into from
Nov 21, 2019

Conversation

@DirkToewe
Copy link
Contributor

@DirkToewe DirkToewe commented Oct 19, 2019 •
edited by nsthorat
Loading

Implements tf.broadcastTo as requested in #2011.The implementation uses the backend implementation of tf.tile and should therefore be just as fast.

This change is Reviewable

@DirkToewe DirkToewe changed the title Broadcast to tf.broadcastTo Oct 19, 2019
@rthadur rthadur requested a review from dsmilkov October 21, 2019 20:29
@rthadur rthadur self-assigned this Oct 21, 2019
@annxingyuan annxingyuan self-requested a review October 24, 2019 09:39
annxingyuan
annxingyuan suggested changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@annxingyuan annxingyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @DirkToewe , and sorry for the incredibly long wait on this! Just left a few very minor comments :)

@annxingyuan
Copy link
Contributor

annxingyuan commented Nov 21, 2019

@DirkToewe sorry just one last thing - could you use expectArraysClose everywhere, instead of checking for mobile safari? This is what we do in our other tests. After that we'll be good to go :)

@DirkToewe
Copy link
Contributor Author

DirkToewe commented Nov 21, 2019 •
edited
Loading

Okay, I changed it. In tf.linalg.bandPart, I've used the same check. If that's okay I'm going to changed it in that PR as well.

@annxingyuan
Copy link
Contributor

annxingyuan commented Nov 21, 2019

@DirkToewe that would be great! thanks!

@annxingyuan annxingyuan merged commit 5442617 into tensorflow:master Nov 21, 2019
@gaikwadrahul8 gaikwadrahul8 mentioned this pull request May 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsmilkov dsmilkov Awaiting requested review from dsmilkov

1 more reviewer

@annxingyuan annxingyuan annxingyuan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rthadur rthadur

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DirkToewe @annxingyuan @googlebot @rthadur