remove the nodes that are skipped during batch norm folding for control node inputs #2337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangyizhang
approved these changes
Nov 6, 2019
Contributor
kangyizhang
left a comment
kangyizhang
left a comment
There was a problem hiding this comment.
Do you need to update tests?
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @kangyizhang)
pyu10055
commented
Nov 6, 2019
Collaborator
Author
pyu10055
left a comment
pyu10055
left a comment
There was a problem hiding this comment.
The current test should cover this changes.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grappler create output control node if the variable read op is defined within the function.
When we do batch norm folding, some nodes are removed, which causing the control node to
depends on missing nodes. This PR to clean the control node inputs.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is