[Core] Update to TypeScript 3.6.3. #2355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annxingyuan
approved these changes
Nov 8, 2019
dsmilkov
approved these changes
Nov 10, 2019
Contributor
dsmilkov
left a comment
dsmilkov
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 2 of 1 approvals obtained (waiting on @dsmilkov and @nsthorat)
tfjs-core/rollup.config.js, line 55 at r1 (raw file):
typescript({ tsconfigOverride: {compilerOptions: {module: 'ES2015', moduleResolution: 'node'}},
curious why you need to re-specify moduleResolution since tfjs-core/tsconfig.json extends from top-level tsconfig.json which already provides that
nsthorat
commented
Nov 11, 2019
Contributor
Author
nsthorat
left a comment
nsthorat
left a comment
There was a problem hiding this comment.
Reviewable status:
tfjs-core/rollup.config.js, line 55 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
curious why you need to re-specify moduleResolution since tfjs-core/tsconfig.json extends from top-level tsconfig.json which already provides that
Removed it not needed!
nsthorat
pushed a commit
that referenced
this pull request
Nov 12, 2019
This reverts commit a42cb30.
nsthorat
pushed a commit
that referenced
this pull request
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't update all packages together because tfjs-core needs to publish without @types/webgl2 to avoid conflicting with the types provided by the new typescript version.
This change is