[WASM] Add Addn used by MobileNet
#2408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annxingyuan
approved these changes
Nov 19, 2019
Contributor
annxingyuan
left a comment
annxingyuan
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, and @tafsiri)
tfjs-backend-wasm/src/cc/BUILD, line 154 at r1 (raw file):
":util", ], )
Should we add to the all_kernels manifest as well?
dsmilkov
commented
Nov 19, 2019
Contributor
Author
dsmilkov
left a comment
dsmilkov
left a comment
There was a problem hiding this comment.
Reviewable status:
tfjs-backend-wasm/src/cc/BUILD, line 154 at r1 (raw file):
Previously, annxingyuan (Ann Yuan) wrote…
Should we add to the all_kernels manifest as well?
good catch. Added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Addnused by MobileNetFEATURE
This change is