[WIP]webgpu: Don't use Int32Array.from #2430
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PERF Per testing, we find that Int32Array.from is very slow on windows. If we use 'new Int32Array' to replace 'Int32Array.from', the fromPixels can speed up 3x~5x on different windows platforms. With this change, the posenet demo can speedup 2x~3x on plaforms that fromPixels are bottleneck.
qjia7
changed the title
Contributor
|
@qjia7 just checking - is this ready for review? |
Contributor
Author
@annxingyuan I filed a chrome bug https://bugs.chromium.org/p/chromium/issues/detail?id=1028538 to track this issue. It seems that it should be fixed in v8 engine. And Shaobo in our team is doing the copyImageBitmapToTexture so that we don't need to read data back to cpu. In that time, these codes will be removed. The code is ready. But I am not sure if this patch is still needed. |
Contributor
Author
|
This change was merged with #2451. Close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PERF
Per testing, we find that Int32Array.from is very slow on windows.
If we use 'new Int32Array' to replace 'Int32Array.from', the fromPixels
can speed up 3x-5x on different windows platforms. With this change,
the posenet demo can speedup 2x-3x on plaforms that fromPixels are
bottleneck.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is