Skip to content

Conversation

@axinging
Copy link
Contributor

@axinging axinging commented Nov 28, 2019

FEATURE
Fix: #2362

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@axinging axinging changed the title [webgpu] Add fusedConv2d [webgpu] Add fusedConv2d kernel Nov 28, 2019
@annxingyuan
Copy link
Contributor

@axinging Thank you! Our build is failing because you are trying to import fused_util from within backend_webgpu, but it only exists within core.

Could you instead import Activation from backend_util?

Also, please export FusedConv2DConfig from backend_util (currently it only exports Activation). Then in backend_webgpu you can import FusedConv2DConfig from @tensorflow/tfjs-core/dist/fused_util, adding a TODO to import it from backend_util upon the next release of core.

@annxingyuan annxingyuan self-requested a review December 2, 2019 15:00
Copy link
Contributor

@annxingyuan annxingyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment.

@annxingyuan
Copy link
Contributor

Hi @axinging - is this ready for another look? Would you mind merging master into your branch and resolving any conflicts? Thank you!

@axinging
Copy link
Contributor Author

Done,@annxingyuan

@annxingyuan
Copy link
Contributor

@axinging thanks! could you do one more thing: in backend_util.ts, export {Activation, FusedConv2DConfig, FusedBatchMatMulConfig}. then they will be available with the next release of core.

@axinging
Copy link
Contributor Author

@axinging thanks! could you do one more thing: in backend_util.ts, export {Activation, FusedConv2DConfig, FusedBatchMatMulConfig}. then they will be available with the next release of core.

Thanks @annxingyuan, it is ready now. Sorry I forget to update the backend_util in my last commit.

Copy link
Contributor

@annxingyuan annxingyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @axinging !

@annxingyuan annxingyuan merged commit 3fb3529 into tensorflow:master Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[webgpu] Add fusedConv2D kernel.

3 participants