Skip to content

Remove a few unnecessarily mutable exports from tfjs-core #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2019
Merged

Remove a few unnecessarily mutable exports from tfjs-core #2498

merged 2 commits into from
Dec 5, 2019

Conversation

@blickly
Copy link
Contributor

@blickly blickly commented Dec 5, 2019 •
edited by nsthorat
Loading

Mutable ESM exports can be difficult to reason about and are often not necessary.

Remove them in a few places that can use export const instead.

(At Google internally we forbid them and we are now cleaning up existing usages.)

This change is Reviewable

@dsmilkov dsmilkov self-requested a review December 5, 2019 22:56
@dsmilkov
Copy link
Contributor

dsmilkov commented Dec 5, 2019

Thanks!

@dsmilkov dsmilkov merged commit 22e8a1a into tensorflow:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsmilkov dsmilkov Awaiting requested review from dsmilkov

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blickly @dsmilkov @googlebot