Skip to content

Remove a few unnecessarily mutable exports from tfjs-core #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2019
Merged

Remove a few unnecessarily mutable exports from tfjs-core #2498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a92c452
Mark as `const` a non-mutable export
blickly Dec 5, 2019
f943e11
Make a mutable export immutable
blickly Dec 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tfjs-core/src/engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1102,4 +1102,4 @@ function getOrMakeEngine(): Engine {
return ns._tfengine;
}

export let ENGINE = getOrMakeEngine();
export const ENGINE = getOrMakeEngine();
5 changes: 3 additions & 2 deletions tfjs-core/src/jasmine_util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,15 +210,16 @@ export interface TestEnv {
isDataSync?: boolean;
}

export let TEST_ENVS: TestEnv[] = [];
export const TEST_ENVS: TestEnv[] = [];

// Whether a call to setTestEnvs has been called so we turn off
// registration. This allows command line overriding or programmatic
// overriding of the default registrations.
let testEnvSet = false;
export function setTestEnvs(testEnvs: TestEnv[]) {
testEnvSet = true;
TEST_ENVS = testEnvs;
TEST_ENVS.length = 0;
TEST_ENVS.push(...testEnvs);
}

export function registerTestEnv(testEnv: TestEnv) {
Expand Down