Skip to content

[webgpu] Link to tfjs-core@master #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 2, 2020
Merged

[webgpu] Link to tfjs-core@master #2629

merged 13 commits into from
Jan 2, 2020

Conversation

@annxingyuan
Copy link
Contributor

@annxingyuan annxingyuan commented Dec 31, 2019 •
edited
Loading

Changes

  • Link webgpu to tfjs-core@master to avoid having to import from dist/ when waiting for new releases.
  • Exclude failing tests.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

This change is Reviewable

@annxingyuan annxingyuan mentioned this pull request Dec 31, 2019
Merged
@annxingyuan annxingyuan changed the title WIP [webgpu] Link to tfjs-core@master [webgpu] Link to tfjs-core@master Jan 2, 2020
@annxingyuan annxingyuan requested a review from nsthorat January 2, 2020 15:06
@annxingyuan annxingyuan self-assigned this Jan 2, 2020
@nsthorat
Copy link
Contributor

nsthorat commented Jan 2, 2020

Code LGTM, I think your build error is from not compiling core like we do here:
https://github.com/tensorflow/tfjs/blob/master/tfjs-backend-wasm/package.json#L15

@annxingyuan
Copy link
Contributor Author

annxingyuan commented Jan 2, 2020

@nsthorat thanks - I think that worked!

@annxingyuan annxingyuan merged commit 88669b7 into master Jan 2, 2020
@annxingyuan annxingyuan deleted the webgpu_core_master branch January 2, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nsthorat nsthorat nsthorat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@annxingyuan annxingyuan

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@annxingyuan @nsthorat @googlebot