[webgpu] Enable bias and weights for fusedConv2D #2665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axinging
changed the title
Contributor
Author
|
@annxingyuan 𝑃𝑇𝐴𝐿 |
axinging
force-pushed
the
fusedconv_fix
branch
from
14e4a79 to
0f0c8f4
Compare
axinging
force-pushed
the
fusedconv_fix
branch
from
0f0c8f4 to
3510998
Compare
Contributor
Author
|
@annxingyuan PTAL. |
annxingyuan
reviewed
Mar 10, 2020
| { | ||
| include: 'fused conv2d', | ||
| excludes: [ | ||
| 'im2row with prelu', // Actual != expected. |
Contributor
There was a problem hiding this comment.
Hm, how big is the error? I'm surprised that these tests needed to be excluded.
Contributor
Author
There was a problem hiding this comment.
The reported error is like this on Mac:
Arrays differ: actual[7] = 0, expected[7] = -2.5.
Please noted that even with this 𝑃𝑅, some case may fail, I add the followup here: https://github.com/tensorflow/tfjs/pull/2846/files#diff-dcb528c192f70859b8f4333e400b445fR813
annxingyuan
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #2660
This change is