[tfjs-converter] Adjust tfjs-converter build script #2789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the line that copies the compiled_api.ts file into the dist folder.
pyu10055
approved these changes
Feb 25, 2020
Collaborator
pyu10055
left a comment
pyu10055
left a comment
There was a problem hiding this comment.
thanks for the clean up.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained
pyu10055
approved these changes
Feb 25, 2020
Collaborator
pyu10055
left a comment
pyu10055
left a comment
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the portion that copies the
compiled_api.tsfile into thedistfolder. This seems to be leftover from when compiled_api used to be a javascript file and not typescript. Currently, I don't really see a reason to still copy the typescript file over. Let me know if there is a reason I'm missing.This will also prevent issues like in #2400.
This change is