Skip to content

Conversation

@annxingyuan
Copy link
Contributor

@annxingyuan annxingyuan commented Mar 4, 2020

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, and @nsthorat)


tfjs-backend-wasm/src/index.ts, line 20 at r1 (raw file):

import './kernels/all_kernels';
export {BackendWasm, setWasmPath} from './backend_wasm';
export {version as version_wasm} from './version';

add a unit test for this like we do in other packages: https://github.com/tensorflow/tfjs/blob/master/tfjs-layers/src/version_test.ts

@annxingyuan annxingyuan merged commit 28e56fc into master Mar 4, 2020
@annxingyuan annxingyuan deleted the export_wasm_version branch March 4, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants