-
Notifications
You must be signed in to change notification settings - Fork 2k
[layers]Test against head. #2831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nsthorat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @caisq, @dsmilkov, @nsthorat, and @pyu10055)
| "build": "tsc", | ||
| "build-core": "cd ../tfjs-core && yarn && yarn build", | ||
| "build-core-ci": "cd ../tfjs-core && yarn && yarn build-ci", | ||
| "build-npm": "./scripts/build-npm.sh", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A suggestion: to defend against publishing layers with a linked core package, we should have build-npm.sh check that "@tensorflow/tfjs-core": points to a version and not "link:../tfjs-core" . Likewise for the other build-npm.sh scripts in the other packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a reasonable suggestion for extra safety but in practice this won’t happen because of the release script :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The release script makes sure it uses a pinned version. But yes, it can't prevent link leak to npm if package is released manually. I will add the safe guard in another PR.
|
One thing I forgot about, you need to do something like this: https://github.com/tensorflow/tfjs/blob/master/tfjs-backend-wasm/package.json#L23 This script runs every time we build (or do anything for development) to make sure that when developing we're reverting the changes of the version pinning of the release script back to |
Exactly, I noticed that too. Created another PR for that: #2834 |
This change is