Skip to content

Conversation

@lina128
Copy link
Collaborator

@lina128 lina128 commented Mar 6, 2020

This change is Reviewable

@lina128 lina128 changed the title [layers]Remove use of browserstack. [data]Remove use of browserstack. Mar 6, 2020
@lina128 lina128 requested review from dsmilkov and nsthorat March 6, 2020 17:55
Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov, @lina128, and @nsthorat)


tfjs-data/package.json, line 25 at r1 (raw file):

    "jasmine-core": "~3.1.0",
    "karma": "~4.0.1",
    "karma-browserstack-launcher": "~1.4.0",

remove this


tfjs-data/package.json, line 54 at r1 (raw file):

    "test-ci": "ts-node src/test_node.ts",
    "test-snippets": "ts-node ./scripts/test_snippets.ts",
    "run-browserstack": "karma start --browsers='bs_firefox_mac,bs_chrome_mac' --singleRun",

remover this

@lina128
Copy link
Collaborator Author

lina128 commented Mar 6, 2020

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov, @lina128, and @nsthorat)

tfjs-data/package.json, line 25 at r1 (raw file):

    "jasmine-core": "~3.1.0",
    "karma": "~4.0.1",
    "karma-browserstack-launcher": "~1.4.0",

remove this

tfjs-data/package.json, line 54 at r1 (raw file):

    "test-ci": "ts-node src/test_node.ts",
    "test-snippets": "ts-node ./scripts/test_snippets.ts",
    "run-browserstack": "karma start --browsers='bs_firefox_mac,bs_chrome_mac' --singleRun",

remover this

Done.

Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! 2 of 1 approvals obtained (waiting on @dsmilkov and @lina128)

@lina128 lina128 merged commit bbe07d4 into tensorflow:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants