Skip to content

[data]Remove use of browserstack. #2833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2020
Merged

[data]Remove use of browserstack. #2833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd83901
[layers]Remove use of browserstack.
lina128 Mar 6, 2020
55f3eaa
Remove browserstack commands.
lina128 Mar 6, 2020
ec9b1b3
Merge branch 'master' into temp
lina128 Mar 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions tfjs-data/cloudbuild.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,28 +30,38 @@ steps:
args: ['install']
waitFor: ['build-layers']

# Run data tests.
# Run lint.
- name: 'node:10'
dir: 'tfjs-data'
entrypoint: 'yarn'
id: 'test'
args: ['test-ci']
id: 'lint'
args: ['lint']
waitFor: ['yarn']

# Build the project.
- name: 'node:10'
dir: 'tfjs-data'
entrypoint: 'yarn'
id: 'build'
args: ['build']
waitFor: ['yarn']
env: ['BROWSERSTACK_USERNAME=deeplearnjs1', 'NIGHTLY=$_NIGHTLY']
secretEnv: ['BROWSERSTACK_KEY']

# Run tests in node.
- name: 'node:10'
dir: 'tfjs-data'
entrypoint: 'yarn'
id: 'test'
args: ['test']
waitFor: ['build']

# Run data snippets tests.
- name: 'node:10'
dir: 'tfjs-data'
entrypoint: 'yarn'
id: 'test-snippets'
args: ['test-snippets']
waitFor: ['yarn']
waitFor: ['build']

secrets:
- kmsKeyName: projects/learnjs-174218/locations/global/keyRings/tfjs/cryptoKeys/enc
secretEnv:
BROWSERSTACK_KEY: CiQAkwyoIW0LcnxymzotLwaH4udVTQFBEN4AEA5CA+a3+yflL2ASPQAD8BdZnGARf78MhH5T9rQqyz9HNODwVjVIj64CTkFlUCGrP1B2HX9LXHWHLmtKutEGTeFFX9XhuBzNExA=
timeout: 1800s
logsBucket: 'gs://tfjs-build-logs'
substitutions:
Expand Down
7 changes: 2 additions & 5 deletions tfjs-data/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"jasmine": "3.1.0",
"jasmine-core": "~3.1.0",
"karma": "~4.0.1",
"karma-browserstack-launcher": "~1.4.0",
"karma-chrome-launcher": "~2.2.0",
"karma-firefox-launcher": "~1.1.0",
"karma-jasmine": "~1.1.1",
Expand All @@ -47,12 +46,10 @@
"build-npm": "./scripts/build-npm.sh",
"link-local": "yalc link",
"publish-local": "rimraf dist/ && yarn build-npm && yalc push",
"test": "yarn build-core && yarn build-layers && yarn && karma start",
"test": "yarn build-core && yarn build-layers && yarn && ts-node src/test_node.ts",
"test-browsers": "karma start --browsers='Chrome,Firefox'",
"test-node": "ts-node src/test_node.ts",
"test-ci": "./scripts/test-ci.sh",
"test-ci": "ts-node src/test_node.ts",
"test-snippets": "ts-node ./scripts/test_snippets.ts",
"run-browserstack": "karma start --browsers='bs_firefox_mac,bs_chrome_mac' --singleRun",
"lint": "tslint -p . -t verbose"
},
"peerDependencies": {
Expand Down
3 changes: 1 addition & 2 deletions tfjs-data/scripts/test-ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,4 @@ set -e
# Regular testing.
yarn build
yarn lint
yarn test-node
yarn run-browserstack
yarn test
Loading