[webgpu] Fix dilation and add stride 2 filter 3x3 same conv2d test case #2846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axinging
force-pushed
the
add_conv2d_test
branch
from
a2c6b39 to
e538f1f
Compare
axinging
changed the title
axinging
force-pushed
the
add_conv2d_test
branch
from
e538f1f to
f823fd9
Compare
axinging
force-pushed
the
add_conv2d_test
branch
from
f823fd9 to
f387e44
Compare
axinging
changed the title
axinging
changed the title
Contributor
Author
|
@annxingyuan PTAL. |
axinging
changed the title
axinging
changed the title
NALLEIN
pushed a commit
to NALLEIN/tfjs
that referenced
this pull request
Apr 15, 2020
annxingyuan
approved these changes
Apr 18, 2020
Contributor
annxingyuan
left a comment
annxingyuan
left a comment
There was a problem hiding this comment.
Thank you @axinging ! Sorry for the massive delay!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cases included in this PR may fail when dilation and padding (padding is fixed in another PR: #2993) are no properly applied.
Currently there is only one (fused)conv2d test case, "throws when both stride and dilation are greater than 1", whose strides are [2, 1], and filter size is 2x2, with valid padding. And this case can not capture the dilation and padding misuse very well.
This PR adds stride [2,2] and filter 3x3, with same padding. The pattern is originated from handpose model (https://github.com/tensorflow/tfjs-models/tree/master/handpose). Noted, to make these case pass on WebGPU backend, PR #2993 should also be applied.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is