Update README.md #2956
Merged
Update README.md #2956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmilkov
reviewed
Mar 24, 2020
Contributor
dsmilkov
left a comment
dsmilkov
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @dsmilkov, @nsthorat, and @rthadur)
tfjs-node/README.md, line 55 at r1 (raw file):
$ xcode-select --installFor Mac OS Catalina please follow troubleshooting check out MAC_OS_CATALINA_TROUBLESHOOTING.
to avoid some repetition:
For Mac OS Catalina please follow [this guide](....) to install node-gyp.
Contributor
Author
|
@dsmilkov updated, thank you. |
dsmilkov
approved these changes
Mar 30, 2020
Contributor
dsmilkov
left a comment
dsmilkov
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @dsmilkov and @nsthorat)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation for Xcode installation for MAC_OS_CATALINA refer
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is