Skip to content

fix tensor array gather #3157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2020
Merged

fix tensor array gather #3157

merged 1 commit into from
Apr 28, 2020

Conversation

@pyu10055
Copy link
Collaborator

@pyu10055 pyu10055 commented Apr 28, 2020 •
edited by nsthorat
Loading

In TF tensor array gather op, the indices can be longer than the tensor available in the array.
This aligns our implementation with TF.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

This change is Reviewable

@pyu10055 pyu10055 requested a review from lina128 April 28, 2020 16:47
@pyu10055 pyu10055 requested a review from annxingyuan April 28, 2020 17:21
annxingyuan
annxingyuan approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@annxingyuan annxingyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pyu10055 pyu10055 merged commit 36f2863 into master Apr 28, 2020
@pyu10055 pyu10055 deleted the fix_ta_gather branch April 28, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lina128 lina128 Awaiting requested review from lina128

1 more reviewer

@annxingyuan annxingyuan annxingyuan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pyu10055 @annxingyuan @googlebot