Skip to content

[core] Change inputs to matMul test to avoid precision issues in Safari as stopgap. #3160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 44 commits into from
Closed

[core] Change inputs to matMul test to avoid precision issues in Safari as stopgap. #3160

wants to merge 44 commits into from

Conversation

@annxingyuan
Copy link
Contributor

@annxingyuan annxingyuan commented Apr 28, 2020 •
edited by nsthorat
Loading

Same fix from #3142

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

This change is Reviewable

@annxingyuan annxingyuan requested a review from lina128 April 28, 2020 17:40
@annxingyuan annxingyuan self-assigned this Apr 28, 2020
@lina128
Copy link
Collaborator

lina128 commented Apr 28, 2020

Hi Ann, I guess this branch carries changes for another PR?

@annxingyuan
Copy link
Contributor Author

annxingyuan commented Apr 29, 2020

@lina128 oops - you are right :) here's a new PR: #3171

@annxingyuan annxingyuan deleted the fix_safari_test branch April 29, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lina128 lina128 Awaiting requested review from lina128

Assignees

@annxingyuan annxingyuan

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@annxingyuan @lina128 @googlebot