Skip to content

silence warning about overriding gradients #3572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2020
Merged

silence warning about overriding gradients #3572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c0964e
silience warning about overriding gradients
tafsiri Jul 7, 2020
a6e5cb0
Merge branch 'master' into 3537-gradient-warnings
tafsiri Jul 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tfjs-core/src/kernel_registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
* limitations under the License.
* =============================================================================
*/
import {env} from './environment';

import {getGlobal} from './global_util';
import {NamedGradientMap} from './tape';
import {Tensor} from './tensor';
Expand Down Expand Up @@ -154,8 +156,13 @@ export function registerKernel(config: KernelConfig) {
*/
export function registerGradient(config: GradConfig) {
const {kernelName} = config;

if (gradRegistry.has(kernelName)) {
console.warn(`Overriding the gradient for '${kernelName}'`);
// TODO (yassogba) after 3.0 assess whether we need to keep this gated
// to debug mode.
if (env().getBool('DEBUG')) {
console.warn(`Overriding the gradient for '${kernelName}'`);
}
}
gradRegistry.set(kernelName, config);
}
Expand Down
3 changes: 2 additions & 1 deletion tfjs-core/src/kernel_registry_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,8 @@ describeWithFlags('gradient registry', ALL_ENVS, () => {
tf.unregisterKernel(kernelName, tf.getBackend());
});

it('warning when registering the same gradient twice', () => {
// tslint:disable-next-line: ban
xit('warning when registering the same gradient twice', () => {
const kernelName = 'MyKernel';
tf.registerGradient({kernelName, gradFunc: () => null});
spyOn(console, 'warn').and.callFake((msg: string) => {
Expand Down