Skip to content

[core] Account for optional inputs in profileKernel. #3697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2020
Merged

[core] Account for optional inputs in profileKernel. #3697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6329b2b
add
annxingyuan Jul 30, 2020
84bd010
fix
annxingyuan Jul 30, 2020
5fe9a59
Merge branch 'master' into fix_profile
annxingyuan Jul 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tfjs-core/src/engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,8 @@ export class Engine implements TensorTracker, DataMover {
totalBytesSnapshot: this.state.numBytes,
tensorsAdded: this.state.numTensors - startingNumTensors,
totalTensorsSnapshot: this.state.numTensors,
inputShapes: Object.keys(inputs).map(key => inputs[key].shape),
inputShapes: Object.keys(inputs).map(
key => inputs[key] != null ? inputs[key].shape : null),
outputShapes: outputs.map(item => item.shape)
});
}
Expand Down
5 changes: 3 additions & 2 deletions tfjs-core/src/profiler_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,11 @@ describeWithFlags('profiler.Profiler', SYNC_BACKEND_ENVS, () => {
}, delayMs * 2);
});

it('profiles nested kernel', doneFn => {
it('profiles nested kernel with optional inputs', doneFn => {
const delayMs = 5;
const queryTimeMs = 10;
const inputs = {'x': tf.tensor1d([1])};
const inputs: {'x': tf.Tensor,
'bias': null} = {'x': tf.tensor1d([1]), 'bias': null};
const extraInfo = '';
const timer = new TestBackendTimer(delayMs, queryTimeMs, extraInfo);
const logger = new TestLogger();
Expand Down