-
Notifications
You must be signed in to change notification settings - Fork 2k
Support for ConvLSTM2D #3702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Support for ConvLSTM2D #3702
Changes from all commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
d09b86d
[Core] Introduce convLSTM2D to KernelBackend
dikatok 50f34cb
initial skeleton for ConvLSTM2DCell
dikatok ebc2535
ConvLSTM2DCellArgs to extend LSTMCellLayerArgs
dikatok 960a236
Merge branch 'master' into conv-lstm
dikatok 0a5c622
Merge branch 'conv-lstm' of https://github.com/dikatok/tfjs into conv…
dikatok 0b58c7e
Create helper function getCartesianProductOfValues
dikatok 78656a7
Merge branch 'master' into conv-lstm
dikatok 5cb8c8a
ConvLSTM2DCell
dikatok 4fa4bca
Clean ConvLSTM2DCell
dikatok 886e7a1
Skeleton for ConvLSTM2D
dikatok a93a50d
Support more than 3D input spec in RNN layer
dikatok 25e3a9f
Test ConvLSTM2D Serialization and Deserialization
dikatok e4bffa9
Tidy up convolutional_recurrent imports
dikatok a9cd1e0
Exports convLstm2d in export_layers
dikatok 56a1217
Unit test ConvLSTM2D Symbolic
dikatok 1d5fcd0
Omit cell arg from ConvLSTM2D
dikatok 27cd0e7
More ConvLSTM2D Symbolic tests
dikatok 3c41f9a
update convolutional_recurrent tests
dikatok 85fc2a5
Revert "update convolutional_recurrent tests"
dikatok 7dbbd45
Update convolutional_recurrent tests
dikatok 806152d
Add reference Python code to obtain results for ConvLSTM2DCell test
dikatok 5748c51
Revert "Add reference Python code to obtain results for ConvLSTM2DCel…
dikatok 15032e4
Add reference Python code to obtain results for ConvLSTM2DCell test
dikatok 49d387c
Revert "[Core] Introduce convLSTM2D to KernelBackend"
dikatok c2c0ba5
Merge branch 'master' into conv-lstm
dikatok 9e08898
Rename ConvLSTM2D recurrentKernel to recurrent_kernel
dikatok 74972f8
Merge branch 'conv-lstm' of https://github.com/dikatok/tfjs into conv…
dikatok e41ad12
Merge branch 'master' into conv-lstm
dikatok ed69273
Merge branch 'master' into conv-lstm
dikatok d091cc0
Fix mul with undefined dropout
dikatok 9157a54
Fix dropout not created
dikatok 15cf9c3
Allow boolean in getCartesianProductOfValues
dikatok ff799f8
ConvLSTM2D Tensor args combination tests
dikatok cc131c7
Merge branch 'conv-lstm' of https://github.com/dikatok/tfjs into conv…
dikatok 52cdced
Clean up convolutional_recurrent_test.ts
dikatok d30a886
Unit test ConvLSTM2D Tensor
dikatok 425c40a
ConvLSTM2D unit test - nested model and BPPT
dikatok e796f39
Merge branch 'master' into conv-lstm
dikatok 77e755b
BPPT > BPTT
dikatok 9be0ed9
Merge branch 'conv-lstm' of https://github.com/dikatok/tfjs into conv…
dikatok 06ab1e8
Merge branch 'master' into conv-lstm
dikatok 592dc46
Merge branch 'conv-lstm' of https://github.com/dikatok/tfjs into conv…
dikatok 8b1cc45
Re-factor convolutional_recurrent to not directly extends RNN classes…
dikatok a349db7
Merge branch 'master' into conv-lstm
dikatok 38a20d2
Merge branch 'master' into conv-lstm
dikatok 4d475e2
code review fix
dikatok ed190d2
Merge branch 'conv-lstm' of https://github.com/dikatok/tfjs into conv…
dikatok 9e7227e
Merge branch 'master' into conv-lstm
dikatok d5f4417
code review fix: more meaningful BPTT tests
dikatok aac3b79
Merge branch 'conv-lstm' of https://github.com/dikatok/tfjs into conv…
dikatok 4864f63
code review fix: fix golden value python code indentation
dikatok 5891fd0
combine generateDropoutMask function for both rnn and convrnn
dikatok 53c9008
fix lint error
dikatok df871e9
jsdoc
dikatok a2a177c
fix jsdoc
dikatok bdff063
update convlstm jsdoc to use tf namespace
dikatok 44d5ba3
fix snippets
dikatok b2e4582
Merge branch 'master' into conv-lstm
dikatok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dsmilkov @pyu10055
I modified this check since the default recurrent initializer in ConvLSTM2DCell is orthogonal which needs to support 4D.
This update seems to be inline too with Python implementation (link below).
https://github.com/tensorflow/tensorflow/blob/6016e8009ff8d9b3afa5ae5bafd052ed51d22f74/tensorflow/python/ops/init_ops.py#L571