[wasm] Pin rules_cc version. #4012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tafsiri
approved these changes
Oct 2, 2020
| entrypoint: 'yarn' | ||
| args: ['test-bundle-size'] | ||
| waitFor: ['yarn', 'build-deps', 'build'] | ||
| # TODO(annxingyuan): Reenable once https://github.com/tensorflow/tfjs/pull/4012 is merged. |
Contributor
There was a problem hiding this comment.
Just curious why this refers to this PR itself (given that the fix is in the PR)? I'm sure there is a reason, just curious to what it might be.
Collaborator
There was a problem hiding this comment.
This reminds me I need to move bundle testing to nightly asap! ^_^
Contributor
Author
|
@tafsiri - |
lina128
approved these changes
Oct 2, 2020
| entrypoint: 'yarn' | ||
| args: ['test-bundle-size'] | ||
| waitFor: ['yarn', 'build-deps', 'build'] | ||
| # TODO(annxingyuan): Reenable once https://github.com/tensorflow/tfjs/pull/4012 is merged. |
Collaborator
There was a problem hiding this comment.
This reminds me I need to move bundle testing to nightly asap! ^_^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is