Skip to content

[wasm] Pin rules_cc version. #4012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 2, 2020
Merged

[wasm] Pin rules_cc version. #4012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
27d669d
test
annxingyuan Oct 2, 2020
3e36019
hbn
annxingyuan Oct 2, 2020
cc47a47
test
annxingyuan Oct 2, 2020
8db36e0
clean
annxingyuan Oct 2, 2020
eb50b24
hbn
annxingyuan Oct 2, 2020
acedad2
reorder
annxingyuan Oct 2, 2020
51edde6
hbn
annxingyuan Oct 2, 2020
1137f42
oops
annxingyuan Oct 2, 2020
5599dc9
add
annxingyuan Oct 2, 2020
382893f
fix
annxingyuan Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tfjs-backend-wasm/WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ git_repository(

http_archive(
name = "rules_cc",
strip_prefix = "rules_cc-master",
urls = ["https://github.com/bazelbuild/rules_cc/archive/master.zip"],
sha256 = "90d5a66950b492cbf86201cdc49c4b59796a85a4eb9fd63c07afe5f7132ea623",
strip_prefix = "rules_cc-8346df34b6593b051403b8e429db15c7f4ead937",
urls = [
"https://github.com/bazelbuild/rules_cc/archive/8346df34b6593b051403b8e429db15c7f4ead937.zip",
],
)
13 changes: 7 additions & 6 deletions tfjs-backend-wasm/cloudbuild.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,13 @@ steps:
waitFor: ['build']

# Check bundle size.
- name: 'gcr.io/learnjs-174218/wasm'
dir: 'tfjs-backend-wasm'
id: 'test-bundle-size'
entrypoint: 'yarn'
args: ['test-bundle-size']
waitFor: ['yarn', 'build-deps', 'build']
# TODO(annxingyuan): Reenable once https://github.com/tensorflow/tfjs/pull/4012 is merged.
Copy link
Contributor

@tafsiri tafsiri Oct 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why this refers to this PR itself (given that the fix is in the PR)? I'm sure there is a reason, just curious to what it might be.

Copy link
Collaborator

@lina128 lina128 Oct 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reminds me I need to move bundle testing to nightly asap! ^_^

# - name: 'gcr.io/learnjs-174218/wasm'
# dir: 'tfjs-backend-wasm'
# id: 'test-bundle-size'
# entrypoint: 'yarn'
# args: ['test-bundle-size']
# waitFor: ['yarn', 'build-deps', 'build']

# Lint bazel files.
- name: 'node:10'
Expand Down