webgpu: support maxPoolWithArgmax kernel #7176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qjia7
approved these changes
Dec 15, 2022
xhcao
force-pushed
the
maxPoolWithArgmax
branch
from
c94507d to
b6ae59e
Compare
Contributor
Author
|
@gyagp please help to review it, there is a pending patch that depends on it. |
xhcao
force-pushed
the
maxPoolWithArgmax
branch
from
b6ae59e to
bcc6b06
Compare
qjia7
approved these changes
Dec 28, 2022
|
|
||
| this.shaderKey = `pool2D_${poolType}`; | ||
| if (computePositions) { | ||
| this.positionStr = flattenPositions ? |
Contributor
There was a problem hiding this comment.
Sorry, missed one nit: Please move positionStr to getUserCode.
qjia7
reviewed
Dec 28, 2022
| this.computePositions ? `var maxValue = 0.0; | ||
| var maxValueFound = 0.0; | ||
| var maxPosition = 0;` : | ||
| ''} |
Contributor
There was a problem hiding this comment.
${
this.computePositions ? `var maxValue = 0.0;
var maxValueFound = 0.0;
var maxPosition = 0;` :
''}
var resultValue = ${
this.poolType === 'avg' ? '0.0' : '-1.0 / pow(10.0, -20.0)'};
var count = 0.0;
->
${
this.computePositions ? `var maxValue = 0.0;
var maxValueFound = 0.0;
var maxPosition = 0;` :
`
var resultValue = ${
this.poolType === 'avg' ? '0.0' : '-1.0 / pow(10.0, -20.0)'};
var count = 0.0;
`}
bcc6b06 to
dde80a7
Compare
xhcao
force-pushed
the
maxPoolWithArgmax
branch
from
dde80a7 to
be6f6b5
Compare
xhcao
force-pushed
the
maxPoolWithArgmax
branch
from
be6f6b5 to
412597b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is