Fix wasm backend test segment faults #7258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyu10055
approved these changes
Jan 10, 2023
Collaborator
pyu10055
left a comment
pyu10055
left a comment
There was a problem hiding this comment.
awesome, thank you for fixing. funny how this does not fail on the CI machine.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @mattsoulanille)
mattsoulanille
approved these changes
Jan 10, 2023
Member
mattsoulanille
left a comment
mattsoulanille
left a comment
There was a problem hiding this comment.
Sorry, clicked the wrong button!
That reason for failure makes perfect sense. Thanks for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the segment faults in matmul wasm backend tests.
The cause of these segment faults is the output buffer's incorrect buffer size - the matmul output of shape [2,1] and [1,2] should be shape [2,2], 4 elements there.
After this PR, the wasm backend tests should always pass without remote build.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is