[webgl] Reduce JS map lookups in webgl backend #7387
Conversation
| private freeTextures?: Record<string, Texture[]> = {}; | ||
| private usedTextures?: Record<string, Texture[]> = {}; |
There was a problem hiding this comment.
Nit: Why is this optional (with ?) but immediately assigned? Does it get deleted somewhere else?
There was a problem hiding this comment.
Yes. TextureManager.dispose() assigns nulls to them, and a lot of tests relies on this behavior (set to null after disposed) to be correct, at least they failed when I tried to make it always not null. There may be some additional guards/checks needed after we turn on the null check, but so far it's fine since it matches the old behavior.
There was a problem hiding this comment.
TextureManager.dispose() means TextureManager's singleton is disposed and thus its freeTextures and usedTextures could be disposed, which does not require freeTextures and usedTextures to be optional.
On the other hand, if freeTextures and usedTextures are optional, whenever they are used, null check is required, causing the runtime to execute more logics.
There was a problem hiding this comment.
Rolled back and added a todo comment
3 participants
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is