Skip to content

Remove unnecessary slice #7414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Remove unnecessary slice #7414

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e7300c
Remove unnecessary slice
Linchenn Feb 24, 2023
173b838
Update webgl_util.ts
Linchenn Feb 24, 2023
96097f2
Merge branch 'master' into slice
Linchenn Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tfjs-backend-webgl/src/webgl_util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,8 +491,8 @@ export function isReshapeFree(shape1: number[], shape2: number[]): boolean {
}

if (shape1.length !== shape2.length) { // One of the shapes is a vector.
const shape1Cols = shape1.slice(-1)[0];
const shape2Cols = shape2.slice(-1)[0];
const shape1Cols = shape1[shape1.length - 1];
const shape2Cols = shape2[shape2.length - 1];
if (shape1Cols === shape2Cols) {
return true;
}
Expand Down