Use dynamic URL for tdb if no tdb server provided #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the local dashboard builds were hard-compiled to use localhost:6363. This creates the problem that if the user chooses a different port, the dashboard will stop working as it still tries to connect to localhost:6363 instead. Therefore I use the window.url.origin to determine where the dashboard is served if the ENV variable is not provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the local dashboard builds were hard-compiled to use localhost:6363. This creates the problem that if the user chooses a different port, the dashboard will stop working as it still tries to connect to localhost:6363 instead. Therefore I use the window.url.origin to determine where the dashboard is served if the ENV variable is not provided.