fix: Only create origin_shield block when explicitly enabled #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the dynamic block was created whenever origin_shield config existed, even with enabled=false. Now only creates the block when enabled=true, preventing unnecessary resource updates.
crussell10
changed the title
Author
|
After further testing, desired state is not being achieved. Setting to false removes the block from the configuration but leaves it enabled in the console (if changing from true to false). |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Member
|
This PR is included in version 6.0.0 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the dynamic block was created whenever origin_shield config existed, even with enabled = false. Now only creates the block when enabled = true, preventing unnecessary resource updates.
Motivation and Context
Prevents unnecessary removal and recreation of origin resources even when no changes have been made, when 'origin_shield' is defined as enabled = false.
Issue
Previously observed in - #142